-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose /query
endpoint to use InfluxQL (#365)
#366
feat: expose /query
endpoint to use InfluxQL (#365)
#366
Conversation
8483830
to
140d9d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
============================================
- Coverage 88.91% 88.31% -0.61%
Complexity 778 778
============================================
Files 169 172 +3
Lines 6864 6998 +134
Branches 364 375 +11
============================================
+ Hits 6103 6180 +77
- Misses 653 707 +54
- Partials 108 111 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andy2003 thanks for your fantastic PR 👍
Is it ready for review?
Yes it is |
c09c19c
to
5facd17
Compare
@bednar Is there anything I can do to get this merged? |
Hi @Andy2003, sorry for the late. We currently discuss how to line up the support of other languages in the our client libraries. I hope so that we will be able to do a review soon and then merge it into Regards |
5facd17
to
7cb475f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your PR 👍 and sorry for the late.
There are few requirements which has to be satisfied before we will merge this PR into master:
- Please add an example how to use the
InfluxQL
intoexamples/src/main/java/example
,examples/README.md
and also satisfy following requirements:
client-core/src/main/java/com/influxdb/internal/AbstractQueryApi.java
Outdated
Show resolved
Hide resolved
client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java
Outdated
Show resolved
Hide resolved
client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/domain/InfluxQLQuery.java
Outdated
Show resolved
Hide resolved
client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andy2003 thanks again for your PR 👍 We are almost done..
client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java
Outdated
Show resolved
Hide resolved
client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java
Outdated
Show resolved
Hide resolved
client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java
Outdated
Show resolved
Hide resolved
client-core/src/main/java/com/influxdb/query/InfluxQLQueryResult.java
Outdated
Show resolved
Hide resolved
client/src/test/java/com/influxdb/client/ITInfluxQLQueryService.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/test/java/com/influxdb/client/ITInfluxQLQueryService.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/influxdb/client/internal/InfluxQLQueryApiImpl.java
Outdated
Show resolved
Hide resolved
6c387ec
to
58c64e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@Andy2003 thanks you very much for this PR
Closes #365
Proposed Changes
Added an endpoint to query against the InfluxQL endpoint (v1)
Checklist
mvn test
completes successfully