Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose /query endpoint to use InfluxQL (#365) #366

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

Andy2003
Copy link
Contributor

@Andy2003 Andy2003 commented Jun 23, 2022

Closes #365

Proposed Changes

Added an endpoint to query against the InfluxQL endpoint (v1)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from 8483830 to 140d9d4 Compare June 23, 2022 13:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #366 (6c387ec) into master (32ac909) will decrease coverage by 0.60%.
The diff coverage is 58.08%.

❗ Current head 6c387ec differs from pull request most recent head 58c64e0. Consider uploading reports for the commit 58c64e0 to get more accurate results

@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
- Coverage     88.91%   88.31%   -0.61%     
  Complexity      778      778              
============================================
  Files           169      172       +3     
  Lines          6864     6998     +134     
  Branches        364      375      +11     
============================================
+ Hits           6103     6180      +77     
- Misses          653      707      +54     
- Partials        108      111       +3     
Impacted Files Coverage Δ
...n/java/com/influxdb/query/InfluxQLQueryResult.java 0.00% <0.00%> (ø)
...java/com/influxdb/client/domain/InfluxQLQuery.java 65.62% <65.62%> (ø)
...influxdb/client/internal/InfluxQLQueryApiImpl.java 82.08% <82.08%> (ø)
...n/java/com/influxdb/internal/AbstractQueryApi.java 53.64% <100.00%> (ø)
...m/influxdb/client/internal/InfluxDBClientImpl.java 89.65% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ac909...58c64e0. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andy2003 thanks for your fantastic PR 👍

Is it ready for review?

@Andy2003
Copy link
Contributor Author

Is it ready for review?

Yes it is

@Andy2003 Andy2003 requested a review from bednar July 5, 2022 07:36
@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from c09c19c to 5facd17 Compare July 5, 2022 09:30
@Andy2003
Copy link
Contributor Author

@bednar Is there anything I can do to get this merged?

@bednar
Copy link
Contributor

bednar commented Jul 13, 2022

Hi @Andy2003,

sorry for the late.

We currently discuss how to line up the support of other languages in the our client libraries. I hope so that we will be able to do a review soon and then merge it into master.

Regards

@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from 5facd17 to 7cb475f Compare July 15, 2022 06:43
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR 👍 and sorry for the late.

There are few requirements which has to be satisfied before we will merge this PR into master:

  • Please add an example how to use the InfluxQL into examples/src/main/java/example, examples/README.md

and also satisfy following requirements:

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Andy2003 Andy2003 requested a review from bednar July 29, 2022 08:32
@Andy2003 Andy2003 requested a review from bednar August 1, 2022 12:42
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andy2003 thanks again for your PR 👍 We are almost done..

@Andy2003 Andy2003 force-pushed the feature/gh-356-influxql-endpoint branch from 6c387ec to 58c64e0 Compare August 2, 2022 07:31
@Andy2003 Andy2003 requested a review from bednar August 2, 2022 07:32
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Andy2003 thanks you very much for this PR

@bednar bednar added this to the 6.5.0 milestone Aug 2, 2022
@bednar bednar merged commit 382c2f3 into influxdata:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose /query endpoint to use influxQL
3 participants