Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add instructions for using Spring Boot prior to version 2.7 #674

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

shengbinxu
Copy link
Contributor

@shengbinxu shengbinxu commented Jan 28, 2024

Closes #

Proposed Changes

  1. When I introduced the influxdb-spring dependency into my Spring Boot 2.3 project, auto-configuration did not take effect, requiring additional code to be added. As a result, I updated the readme to provide instructions.

  2. In the Maven repository influxdb-spring, the dependency for micrometer-registry-influx has already been added. Consequently, developers using influxdb-spring no longer need to manually import the micrometer-registry-influx dependency. Due to package conflicts, the spring-boot-actuator may have relied on an earlier version of the micrometer-core. Therefore, it is necessary to specify a higher version here.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b41ea5) 88.35% compared to head (f09c49e) 88.35%.

❗ Current head f09c49e differs from pull request most recent head d86e248. Consider uploading reports for the commit d86e248 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #674   +/-   ##
=========================================
  Coverage     88.35%   88.35%           
+ Complexity      779      775    -4     
=========================================
  Files           173      173           
  Lines          7078     7078           
  Branches        393      393           
=========================================
  Hits           6254     6254           
  Misses          699      699           
  Partials        125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar changed the title Add instructions for using Spring Boot prior to version 2.7 docs: Add instructions for using Spring Boot prior to version 2.7 Jan 29, 2024
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shengbinxu thanks for your PR!

LGTM 🚀

Just for your information, PR #673 in the influxdb-client-java repository introduces support for Spring Boot 3. Consequently, the newest version of the client will no longer be compatible with Spring Boot 2.x.

@bednar bednar merged commit 50e1142 into influxdata:master Jan 29, 2024
11 checks passed
@bednar bednar added this to the 7.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants