The streaming query API has no possibility to cancel query and to be notified about finished stream #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
============================================
+ Coverage 87.91% 87.97% +0.06%
- Complexity 378 380 +2
============================================
Files 25 25
Lines 1531 1547 +16
Branches 169 172 +3
============================================
+ Hits 1346 1361 +15
Misses 120 120
- Partials 65 66 +1
Continue to review full report at Codecov.
|
|
LGTM |
majst01
reviewed
Sep 11, 2018
FAQ.md
Outdated
| @@ -102,3 +103,37 @@ SSLv3/TLSv1/TLSv1.1/TLSv1.2 | |||
|
|
|||
| So if the server supports TLS1.2, the communication should be encrypted by TLS 1.2 (during the handshake the client will provide the list of accepted security protocols and the server will pick one, so this case the server would pick TLS 1.2) | |||
|
|
|||
| ## How to use SSL client certificate authentication | |||
There was a problem hiding this comment.
Hi @rhajek,
as the FAQ additions are unrelated to the streaming PR could you please move them to a seperate PR.
|
@bednar you have to resolv the merge conflicts in this branch, after that i will merge. |
|
Hi @majst01, conflicts are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #515