Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database name is optional for Query and BatchPoints. #552

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Database name is optional for Query and BatchPoints. #552

merged 4 commits into from
Jan 22, 2019

Conversation

asashour
Copy link
Contributor

Fixes #548

@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #552 into master will increase coverage by 0.04%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #552      +/-   ##
============================================
+ Coverage     88.09%   88.14%   +0.04%     
- Complexity      698      702       +4     
============================================
  Files            68       68              
  Lines          2378     2387       +9     
  Branches        242      246       +4     
============================================
+ Hits           2095     2104       +9     
  Misses          198      198              
  Partials         85       85
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/dto/Query.java 67.5% <100%> (+1.71%) 13 <4> (+1) ⬆️
...ain/java/org/influxdb/dto/BoundParameterQuery.java 95.83% <100%> (+0.18%) 12 <0> (ø) ⬇️
src/main/java/org/influxdb/dto/BatchPoints.java 72.34% <100%> (ø) 23 <1> (+1) ⬆️
src/main/java/org/influxdb/impl/InfluxDBImpl.java 90.46% <88.88%> (+0.11%) 87 <3> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df1581...be47c04. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Jan 21, 2019

With this end user api breaks right ? Any Ideas howto prevent that

@asashour
Copy link
Contributor Author

No, user API doesn't break, there are no methods removed. We just add new methods. (I guess old methods should be deprecated).

@majst01
Copy link
Collaborator

majst01 commented Jan 22, 2019

Hi, i like it, its worth a CHANGELOG.md entry, would you please add one and i will pull.

@majst01 majst01 merged commit 81a9fc6 into influxdata:master Jan 22, 2019
@asashour asashour deleted the databaseName branch January 22, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants