Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatchPoints.Builder.points(Collection) #561

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Add BatchPoints.Builder.points(Collection) #561

merged 3 commits into from
Jan 22, 2019

Conversation

asashour
Copy link
Contributor

Fixes #451

@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #561 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #561      +/-   ##
============================================
+ Coverage     88.14%   88.15%   +<.01%     
  Complexity      702      702              
============================================
  Files            68       68              
  Lines          2387     2389       +2     
  Branches        246      246              
============================================
+ Hits           2104     2106       +2     
  Misses          198      198              
  Partials         85       85
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/dto/BatchPoints.java 72.91% <100%> (+0.57%) 23 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a9fc6...b5d1fda. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Jan 22, 2019

Thanks, also worth a CHANGELOG.md entry, if added i will pull

@asashour
Copy link
Contributor Author

Thanks, done.

As a side node, I guess many issues should be closed, as they have been replied, or stated as invalid.

@majst01 majst01 merged commit d56b95a into influxdata:master Jan 22, 2019
@asashour asashour deleted the points branch January 22, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants