Enable selecting variable values in time machine #12678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chnn
force-pushed
the
ui-time-machine-vars
branch
2 times, most recently
from
eecef1f
to
dbda60b
Compare
chnn
commented
Mar 18, 2019
| @@ -37,7 +39,11 @@ class ToolbarFunction extends PureComponent<Props, State> { | |||
| onMouseLeave={this.handleStopHover} | |||
| data-testid={testID} | |||
| > | |||
| {this.tooltip} | |||
| {isActive && ( | |||
There was a problem hiding this comment.
The variables list in the script editor needed the same style of tooltips as the functions list, so I extracted them to a component called BoxTooltip.
chnn
commented
Mar 18, 2019
| const {expanded} = this.state | ||
|
|
||
| if (expanded) { |
There was a problem hiding this comment.
Hey @alexpaxton @mavarius, could I get your opinion on this change? I removed the validation / dev assertion that a Dropdown must have at least 1 child.
I needed to display a dropdown that loads its items asynchronously. So it may no have any items (either hasn't been loaded, or has been loaded but no results were returned).
121watts
approved these changes
Mar 18, 2019
121watts
approved these changes
Mar 18, 2019
chnn
force-pushed
the
ui-time-machine-vars
branch
from
dbda60b
to
1cb96b3
Compare
chnn
force-pushed
the
ui-time-machine-vars
branch
from
1cb96b3
to
fd0f49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12122