-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(httpd): Add option to authenticate debug/pprof and ping endpoints #15222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
approved these changes
Sep 20, 2019
jacobmarble
reviewed
Sep 20, 2019
jacobmarble
approved these changes
Sep 20, 2019
gunnaraasen
force-pushed
the
ga-add-auth
branch
from
September 20, 2019 21:11
c357792
to
77686e3
Compare
I've updated the example config with a note about the |
If someone needs a profile from an OSS instance with pprof auth enabled, I
guess they grab it with curl (or whatever) instead of the `go` CLI?
|
gunnaraasen
force-pushed
the
ga-add-auth
branch
from
September 20, 2019 23:32
77686e3
to
0c4703a
Compare
Yup, a profile would need to be pulled with
|
jacobmarble
pushed a commit
that referenced
this pull request
Sep 24, 2019
jacobmarble
added a commit
that referenced
this pull request
Sep 24, 2019
Wow! I think, that there is an error, but found that init-influxdb.sh doesn’t work without -e INFLUXDB_HTTP_AUTH_ENABLED=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10167
Adds
pprof-auth-enabled
andping-auth-enabled
configuration options which can enable authentication on all/debug
and/ping
endpoints. This also covers the prometheus/metrics
and deprecated/status
endpoints.With these additions, all InfluxDB endpoints will require authentication with the following configuration:
Note that
go tool pprof
does not support authentication so it will not work whenpprof-auth-enabled
is enabled.