Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--test does not return a correct status #6278

Closed
fhriley opened this issue Aug 16, 2019 · 0 comments · Fixed by #6279
Closed

--test does not return a correct status #6278

fhriley opened this issue Aug 16, 2019 · 0 comments · Fixed by #6279
Labels
bug unexpected problem or unintended behavior
Milestone
1.11.5

Comments

@fhriley
Copy link
Contributor

fhriley commented Aug 16, 2019

I was attempting to add simple telegraf testing to my CI using the --test option. However, as you can see here, telegraf will not return an error if any of the input plugins fails. Since the Test() method doesn't return an error there, the telegraf command will also not return an error and will have a status code of 0, which will pass in CI.
fhriley added a commit to fhriley/telegraf that referenced this issue Aug 16, 2019
@fhriley
Fix influxdata#6278: Add test-status flag.
ba891fd 
This flag will cause telegraf to have a non-zero exit status if any of the input plugins fail during test mode.
fhriley added a commit to fhriley/telegraf that referenced this issue Aug 16, 2019
@fhriley
Fix influxdata#6278: Fix exec input plugin to return status correctly.
f405e85
fhriley added a commit to fhriley/telegraf that referenced this issue Aug 16, 2019
@fhriley
Fix influxdata#6278: Fix exec input plugin to return status correctly.
0712150
@danielnelson danielnelson added the bug unexpected problem or unintended behavior label Aug 16, 2019
@fhriley fhriley mentioned this issue Aug 16, 2019
Merged
3 tasks
fhriley added a commit to fhriley/telegraf that referenced this issue Aug 16, 2019
@fhriley
Fix influxdata#6278: Have test mode return an error if any of the inp…
94a257b 
…ut plugins produced an error.
@danielnelson danielnelson added this to the 1.11.5 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Milestone
1.11.5
Development

Successfully merging a pull request may close this issue.

Return error status from --test if any of the input plugins produced an error fhriley/telegraf
2 participants
@fhriley @danielnelson