Return error status from --test if any of the input plugins produced an error #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request, I have a few high level ideas: I don't think we need to add a new cli flag, if there are any errors during test we can return 1. For plugins like exec with multiple commands, or plugins that connect to multiple remote services, we don't actually want to fish the error out and instead use the AddError function on the accumulator. This prevents multiple logging and keeps us from needing lists of errors. What we should do in Test() is call |
…ut plugins produced an error.
|
Updated based on your comments. |
danielnelson
changed the title
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple notes:
I added a separate
--test-statusoption totelegrafto implement this. I did this to maintain backwards compatibility in case anyone is depending on the current behavior of always returning 0.The exec plugin was always returning no error. I fixed this plugin since we are using it. It is possible other plugins are also not correctly returning any errors.
closes: #6278
Required for all PRs: