Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate nagios parser to new style #11402

Merged
merged 2 commits into from
Jun 30, 2022
Merged

feat: Migrate nagios parser to new style #11402

merged 2 commits into from
Jun 30, 2022

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Jun 28, 2022

resolves #11360

This PR migrates the nagios parser to the new-style parser structure. The change is backward compatible. Furthermore, we cleanup the parser a bit.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 28, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this one @sspaink! One comment about the superfluous Init...

plugins/parsers/nagios/parser.go Outdated Show resolved Hide resolved
plugins/parsers/nagios/parser.go Outdated Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @sspaink!

@srebhan srebhan self-assigned this Jun 29, 2022
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Jun 29, 2022
@telegraf-tiger
Copy link
Contributor

@sspaink sspaink merged commit 9e50853 into master Jun 30, 2022
@sspaink sspaink deleted the migratenagios branch June 30, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate nagios to new parser structure
3 participants