-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add example output section to HTTP plugin #11497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ignoring the URL text means that reading these in a text editor doesn't actually make the line length 80 characters anymore. And the user will have random lines that shoot out.
True, but I was thinking maybe links could be the exception? In this case the link even on its own line exceed the 80 character limit. My main motivation is just to get the green check mark, so I could perhaps just shorten the URL (this seems legit?) or not include it? Although the example output seems a bit random without the context of the article. |
Have you seen the reference-style link method? I wasn't aware of this till Dave went through updating the other READMEs
|
I didn't know you could do that! Seems like a good solution to me, I've updated the PR accordingly. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
(cherry picked from commit 2d357d4)
This pull request:
example output
section to the http plugin readme to resolve linter error I noticed here: https://github.com/influxdata/telegraf/runs/7306583417?check_suite_focus=true, this failing in an unrelated PR is probably something that needs to be fixed in the github action but I didn't address this.