-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(inputs.modbus): README changes regarding request.tags #11541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for fixing this @mrxaxen! Much appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrxaxen thanks for fixing this issue. Can you please change the erroneous sections also in the sample*.conf
and then run make docs
!?
The background is that the sample*.conf
files are embedded into the README.md which would override your changes...
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Hey @srebhan! Changed the configuration files (found 2, hoping that's all). Not sure about the CI runs, since's one's reporting on the first commit's message which was accepted last time, and one's reporting on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @mrxaxen for the fix!
(cherry picked from commit f96755c)
Required for all PRs
Just came across the same problem, hoping it'll save a couple of minutes for others in the future.
resolves #10965