Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(inputs.modbus): README changes regarding request.tags #11541

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

mrxaxen
Copy link
Contributor

@mrxaxen mrxaxen commented Jul 22, 2022

Required for all PRs

Just came across the same problem, hoping it'll save a couple of minutes for others in the future.
resolves #10965

srebhan
srebhan previously approved these changes Jul 25, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing this @mrxaxen! Much appreciated!

@srebhan srebhan self-assigned this Jul 25, 2022
@srebhan srebhan added docs Issues related to Telegraf documentation and configuration descriptions fix pr to fix corresponding bug area/modbus labels Jul 25, 2022
@srebhan srebhan dismissed their stale review July 25, 2022 08:15

One more thing to fix...

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrxaxen thanks for fixing this issue. Can you please change the erroneous sections also in the sample*.conf and then run make docs!?

The background is that the sample*.conf files are embedded into the README.md which would override your changes...

@mrxaxen
Copy link
Contributor Author

mrxaxen commented Jul 25, 2022

Hey @srebhan! Changed the configuration files (found 2, hoping that's all). Not sure about the CI runs, since's one's reporting on the first commit's message which was accepted last time, and one's reporting on statsd which i have not laid my hands on. Anyways, this is my very first PR here, i'm not really familiar with conventional commits either so pointers are appriciated.

@srebhan srebhan changed the title docs(inputs.modbus):README changes regarding request.tags docs(inputs.modbus): README changes regarding request.tags Jul 25, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @mrxaxen for the fix!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 25, 2022
@powersj powersj merged commit f96755c into influxdata:master Jul 25, 2022
reimda pushed a commit that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus docs Issues related to Telegraf documentation and configuration descriptions fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.modbus.request.tags give error cannot unmarshal TOML array table into map
3 participants