-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CloudWatch rate limit to config #1673
Conversation
thanks @tmonk42, but you should also set 10 to be the default in the |
I dug through several other input plugins and found a common pattern of adding a setDefaults or setDefaultValues function inside of Gather(). I opted to follow this pattern rather than set it in init(). I hope that is acceptable. |
sorry, that's not acceptable, please put it in the init() function. There's no point in calling setDefaults on every Gather when it can only be set once. If there are other plugins doing that then they should be changed to use the init() method. |
https://github.com/influxdata/telegraf/blob/master/plugins/inputs/conntrack/conntrack.go#L40 Looks like the Ceph input plugin was updated to move to the init() function for defaults just a few hours ago. I'll update again :) thank you! |
thanks @tmonk42! |
Required for all PRs:
Reference #1670