Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for last GC pause time #2121

Merged
merged 2 commits into from
Dec 16, 2016

Conversation

tevjef
Copy link
Contributor

@tevjef tevjef commented Dec 3, 2016

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

@@ -202,6 +203,7 @@ func (i *InfluxDB) gatherURL(
"next_gc": m.NextGC,
"last_gc": m.LastGC,
"pause_total_ns": m.PauseTotalNs,
"pause_ns": m.PauseNs[(m.NumGC+255)%256],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if NumGC == 0? Should the index be 255?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index doesn't matter when NumGC == 0 since every element in PauseNs[0:256] will be zero.

@tevjef
Copy link
Contributor Author

tevjef commented Dec 10, 2016

@sparrc Any reason why this wouldn't make the 1.2.0 release?

@sparrc sparrc modified the milestones: 1.2.0, 1.3.0 Dec 13, 2016
@sparrc
Copy link
Contributor

sparrc commented Dec 13, 2016

None in particular, just a large backlog :), I'll try to get it in since it's a rather small change

@sparrc sparrc merged commit 4957717 into influxdata:master Dec 16, 2016
njwhite pushed a commit to njwhite/telegraf that referenced this pull request Jan 31, 2017
maxunt pushed a commit that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants