Keep -config-directory when running as Windows service #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, please update the changelog! |
sparrc
approved these changes
Feb 1, 2017
3 tasks
mlindes
pushed a commit
to Comcast/telegraf
that referenced
this pull request
Feb 6, 2017
* Keep -config-directory when running as Windows service * Update changelog
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Keep -config-directory when running as Windows service * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
When installing a Windows service, the "-config" option is kept. But "-config-directory" was not kept.
The PR handle "-config-directory" the same way as "-config" and keep the value used when installing the service and when running the service.