Statsd listener plugin #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
statsd
branch
13 times, most recently
from
bc41b3b
to
1a37001
Compare
sparrc
force-pushed
the
statsd
branch
16 times, most recently
from
2c25ddd
to
e68b6dd
Compare
sparrc
force-pushed
the
statsd
branch
2 times, most recently
from
c64af32
to
badbd5c
Compare
sparrc
force-pushed
the
statsd
branch
17 times, most recently
from
db2fca1
to
17bf20a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @pauldix @toddboom @otoolep Code review for the ServicePlugin interface, this is basically what a statsd "service" plugin would look like, and what all service plugins going forward would look like.
Note that this will live in the same general
pluginsdirectory, but it will satisfy the newServicePlugininterface (which is an extension of thePlugin) interface.