Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker engine-api library is deprecated(2071) #2379

Closed
wants to merge 1 commit into from
Closed

docker engine-api library is deprecated(2071) #2379

wants to merge 1 commit into from

Conversation

rsingh2411
Copy link
Contributor

@rsingh2411 rsingh2411 commented Feb 7, 2017

I have made the changes in code and test file and all tests are also passed
go test -v *.go === RUN TestDockerGatherContainerStats --- PASS: TestDockerGatherContainerStats (0.00s) === RUN TestDockerGatherInfo --- PASS: TestDockerGatherInfo (0.00s) PASS ok command-line-arguments 0.008s

After adding my changes following error was coming go install -ldflags \ "-X main.version=dev-49-gc8cc01b -X main.commit=c8cc01b -X main.branch=master" ./... github.com/influxdata/telegraf/plugins/inputs/docker plugins/inputs/docker/docker.go:103: cannot use c (type *client.Client) as type DockerClient in assignment: *client.Client does not implement DockerClient (wrong type for ContainerList method) have ContainerList("github.com/docker/docker/vendor/golang.org/x/net/context".Context, types.ContainerListOptions) ([]types.Container, error) want ContainerList("golang.org/x/net/context".Context, types.ContainerListOptions) ([]types.Container, error) make: *** [build] Error 2

This was because somewhere in code the vendor context was being referred and telegraf refers the vendor context in the first place. I renamed the folder, after wards make ran succesfully. I am new to go, couldn't get solution for that.

@sparrc
Copy link
Contributor

sparrc commented Feb 7, 2017

thanks for the effort, but you'll need to make sure the project builds and all unit tests pass before submitting a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants