docker engine-api library is deprecated(2071) #2379
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the changes in code and test file and all tests are also passed
go test -v *.go === RUN TestDockerGatherContainerStats --- PASS: TestDockerGatherContainerStats (0.00s) === RUN TestDockerGatherInfo --- PASS: TestDockerGatherInfo (0.00s) PASS ok command-line-arguments 0.008s
After adding my changes following error was coming
go install -ldflags \ "-X main.version=dev-49-gc8cc01b -X main.commit=c8cc01b -X main.branch=master" ./... github.com/influxdata/telegraf/plugins/inputs/docker plugins/inputs/docker/docker.go:103: cannot use c (type *client.Client) as type DockerClient in assignment: *client.Client does not implement DockerClient (wrong type for ContainerList method) have ContainerList("github.com/docker/docker/vendor/golang.org/x/net/context".Context, types.ContainerListOptions) ([]types.Container, error) want ContainerList("golang.org/x/net/context".Context, types.ContainerListOptions) ([]types.Container, error) make: *** [build] Error 2
This was because somewhere in code the vendor context was being referred and telegraf refers the vendor context in the first place. I renamed the folder, after wards make ran succesfully. I am new to go, couldn't get solution for that.