Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type conflict on windows ping plugin #2462

Merged
merged 2 commits into from
Mar 1, 2017
Merged

Fix type conflict on windows ping plugin #2462

merged 2 commits into from
Mar 1, 2017

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Feb 22, 2017

closes #1433

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)

this is going to require a note in the changelog release notes, because it will break current users of only the windows plugin.

@sparrc
Copy link
Contributor Author

sparrc commented Feb 22, 2017

@marianob85 can you review please?

@marianob85
Copy link
Contributor

marianob85 commented Feb 22, 2017

Done

@sparrc sparrc merged commit a251adb into master Mar 1, 2017
@sparrc sparrc added this to the 1.3.0 milestone Mar 1, 2017
@danielnelson danielnelson deleted the cs1433 branch March 17, 2017 00:12
ssorathia pushed a commit to ssorathia/telegraf that referenced this pull request Mar 25, 2017
@dudusakharovich
Copy link

dudusakharovich commented May 9, 2017

Hey @sparrc

I'm unable to use the ping input on windows machine.
What is the proper configuration which will make it succeed ?

vlamug pushed a commit to vlamug/telegraf that referenced this pull request May 30, 2017
maxunt pushed a commit that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows ping plugin type error
4 participants