Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve redis input documentation #2708

Merged
merged 7 commits into from
May 2, 2017
Merged

Improve redis input documentation #2708

merged 7 commits into from
May 2, 2017

Conversation

ablagoev
Copy link
Contributor

@ablagoev ablagoev commented Apr 25, 2017 •
edited
Loading

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

#2706

danielnelson
danielnelson reviewed Apr 25, 2017
View reviewed changes
Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have two optional suggestions that would make it even better:

  • I think we should sort the list of fields
  • Add field types

Let me know if you are interested in doing these, either way I'll merge it.

@danielnelson danielnelson added this to the 1.3.0 milestone Apr 25, 2017
@danielnelson danielnelson added the docs Issues related to Telegraf documentation and configuration descriptions label Apr 25, 2017
@ablagoev
Copy link
Contributor Author

Hey,

Thank you for the suggestions.

I also thought about sorting them alphabetically, but came to the conclusion to arrange them by context - they are actually arranged in categories: Server, Clients, Memory, Persistance, Stats, Replication, CPU, Cluster. This is the order in which Redis returns them too.

Maybe if I add an empty line so that the grouping is visible it would be better.

I agree about the field types and will add them tomorrow.

@danielnelson
Copy link
Contributor

Can you add it to the CHANGELOG?

@danielnelson danielnelson merged commit 188703e into influxdata:master May 2, 2017
@danielnelson
Copy link
Contributor

Awesome, thanks so much for this!

danielnelson pushed a commit that referenced this pull request May 2, 2017
@ablagoev @danielnelson
Improve redis input documentation (#2708)
5e70cb3
vlamug pushed a commit to vlamug/telegraf that referenced this pull request May 30, 2017
@ablagoev
Improve redis input documentation (influxdata#2708)
a3aa4ad
jeichorn pushed a commit to jeichorn/telegraf that referenced this pull request Jul 24, 2017
@ablagoev @jeichorn
Improve redis input documentation (influxdata#2708)
12bc8ba
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@ablagoev @danielnelson
Improve redis input documentation (#2708)
1da3e41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielnelson danielnelson danielnelson left review comments

Assignees
No one assigned
Labels
docs Issues related to Telegraf documentation and configuration descriptions
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ablagoev @danielnelson