Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health status mapping from string to int. #3551

Merged

Conversation

arkady-emelyanov
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Add status_code field mapping when reporting health status.

@danielnelson
Copy link
Contributor

Thanks for the pull request, I think what may be simpler is if instead of the map we have a function with a switch over each health value.

@arkady-emelyanov
Copy link
Contributor Author

@danielnelson thanks for a quick review. you mean something like that?

@danielnelson danielnelson added this to the 1.6.0 milestone Dec 7, 2017
@danielnelson
Copy link
Contributor

Perfect, I'll merge when the tests finish.

@danielnelson danielnelson added area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Dec 7, 2017
@danielnelson danielnelson merged commit 4d91162 into influxdata:master Dec 7, 2017
@arkady-emelyanov arkady-emelyanov deleted the elasticsearch-status-code branch December 7, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants