Add keep alive support to the TCP mode of statsd #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
the
feat
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar implementation to the socket listener input plugin and its original pull request. Found this was really necessary to keep the server connections clean, because you can't rely on clients always being able to close them (FIN), specially if you are running Telegraf behind a load balancer. Default behaviour is still false, so that it doesn't disrupt existing setups.
Same as the pull request 2697, unit tests for this are hard to accomplish ("There's no ability to query a socket for its current keep-alive setting") but you can observe the behaviour using packet capturing.
Required for all PRs: