Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname to TLS config for SNI support #4747

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Add hostname to TLS config for SNI support #4747

merged 1 commit into from
Sep 27, 2018

Conversation

onurguzel
Copy link
Contributor

x509_cert plugin was creating TLS connection without specifying a
server name for handshake. If there are multiple certificates on the
same host, the first one is received, resulting insecure host warning.

ServerName in tls.Config turns Server Name Indication (SNI) on for the
handshake, which allows virtual hosts on the same server.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

x509_cert plugin was creating TLS connection without specifying a
server name for handshake. If there are multiple certificates on the
same host, the first one is received, resulting insecure host warning.

ServerName in tls.Config turns Server Name Indication (SNI) on for the
handshake, which allows virtual hosts on the same server.
@onurguzel
Copy link
Contributor Author

I only checked the first box, because there is no README.md changes needed and I'm not sure how you feel about badsll.com in unit tests.

@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 26, 2018
@danielnelson danielnelson added this to the 1.8.1 milestone Sep 26, 2018
@danielnelson danielnelson merged commit a21524c into influxdata:master Sep 27, 2018
danielnelson pushed a commit that referenced this pull request Sep 27, 2018
@onurguzel onurguzel deleted the sni-support branch September 27, 2018 09:40
rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants