Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix open error handling in file output #5540

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix open error handling in file output #5540

merged 1 commit into from
Mar 22, 2019

Conversation

danielnelson
Copy link
Contributor

  • Always use OpenFile, this way the file is always opened in append mode.
  • Fix err handling, err was incorrectly shadowed
  • Changed agent so that close errors are reported per plugin (eg [outputs.file])

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the fix pr to fix corresponding bug label Mar 6, 2019
@danielnelson danielnelson added this to the 1.11.0 milestone Mar 6, 2019
@danielnelson danielnelson merged commit 99a390b into master Mar 22, 2019
@danielnelson danielnelson deleted the file-open-err branch March 22, 2019 20:59
@danielnelson danielnelson modified the milestones: 1.11.0, 1.10.2 Mar 27, 2019
danielnelson added a commit that referenced this pull request Mar 27, 2019
@danielnelson
Fix open error handling in file output (#5540)
01f6d89 
(cherry picked from commit 99a390b)
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@danielnelson
Fix open error handling in file output (influxdata#5540)
8b8678d
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
@danielnelson
Fix open error handling in file output (influxdata#5540)
4dda654
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@danielnelson @bitcharmer
Fix open error handling in file output (influxdata#5540)
1eaf7dc
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@danielnelson
Fix open error handling in file output (influxdata#5540)
fa5e3e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@danielnelson @glinton