Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64-encoding/decoding parameters for Google Cloud PubSub plugins #5543

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Mar 6, 2019

Required for all PRs:

  • [x ] Signed CLA.
  • Associated README.md updated.
  • [x ] Has appropriate unit tests.

This enables several GCP services that can and only output base64-encoded JSON to PubSub (and thus input into Telegraf/TICK). Enabled base-64 encoded for output of metrics just because symmetry is nice and it's suggested that PubSub wants base64-encoded data no matter what.

@russorat russorat added this to the 1.10.1 milestone Mar 6, 2019
Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, the entire message is normally base64 encoded? Just double checking because I know in the pubsub push and in some synchronous pull examples only part of the JSON is encoded: https://cloud.google.com/pubsub/docs/pull#synchronous-pull

plugins/inputs/cloud_pubsub/README.md Outdated Show resolved Hide resolved
@emilymye
Copy link
Contributor Author

emilymye commented Mar 6, 2019

@danielnelson This is actually only setting encoded/decoded values for pubsub.Message.Data, which corresponds to the "data" field in a JSON representation of the message sent to the API.

@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 7, 2019
@danielnelson danielnelson merged commit dd67144 into influxdata:master Mar 7, 2019
danielnelson pushed a commit that referenced this pull request Mar 7, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants