Collect info commandstats from redis #5874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
suggested changes
May 17, 2019
| @@ -188,7 +188,10 @@ func (r *Redis) gatherServer(client Client, acc telegraf.Accumulator) error { | |||
| return err | |||
| } | |||
|
|
|||
| rdr := strings.NewReader(info) | |||
| // skip for commandstats if we can't retrieve it. | |||
| cmdstats, _ := client.Info("commandstats").Result() | |||
There was a problem hiding this comment.
Seems this isn't skipping if you can't retrieve, line 194 would be affected as well.
There was a problem hiding this comment.
I'm not sure that which ways is better betwen log an error and let info return default information if we cannot collect command stats and returns an error.
plugins/inputs/redis/redis.go
Outdated
| // db0:keys=2,expires=0,avg_ttl=0 | ||
| // And there is one for each db on the redis instance | ||
| // | ||
| // TODO: write code comments |
| tags["cmdstat"] = strings.TrimPrefix(name, "cmdstat_") | ||
| stats := strings.Split(line, ",") | ||
| for _, stat := range stats { | ||
| kv := strings.Split(stat, "=") |
There was a problem hiding this comment.
Check length to avoid a panic later
plugins/inputs/redis/redis.go
Outdated
| ival interface{} | ||
| err error | ||
| ) | ||
| // only calls that always be int |
There was a problem hiding this comment.
nitpick: rephrase this comment
| fields[kv[0]] = ival | ||
| } | ||
| } | ||
| acc.AddFields("redis_commandstats", fields, tags) |
There was a problem hiding this comment.
It’s hard to be empty because redis are not returns any line if it has no any command calls. Except that commandstats return the result incorrectly.
glinton
added
area/redis
feat
Redis has an info type "commandstats" that can be collect each command statistics inside redis. To make this work, I call info with commandstats argument after called info (default information), append it and then parse metrics. Closes influxdata#5774
wingyplus
force-pushed
the
redis-cmd-stats
branch
from
f0631eb
to
a1b88bf
Compare
3 tasks
|
This functionality was merged in #5926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis has an info type "commandstats" that can be collect each command
statistics inside redis. To make this work, I call info with commandstats
argument after called info (default information), append it and then parse
metrics.
Closes #5774
Required for all PRs: