Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom attributes #5971

Merged
merged 63 commits into from
Aug 15, 2019
Merged

Added support for custom attributes #5971

merged 63 commits into from
Aug 15, 2019

Conversation

prydin
Copy link
Contributor

@prydin prydin commented Jun 7, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Custom attributes is an important construct that allows administrators to tag resources workloads according to custom schemes. This can be used to group assets, tie containers to VMs, classify workload security requirements among many other things. Being able to use these in queries in target solutions such as InfluxDB has been desired by several users of the vSphere plugin.

Custom attribute collection is controlled by the custom_attribute_include and custom_attribute_exclude configuration settings.

* Don't stop collection on partial error
* Compute average if query returned multiple samples for a metric
…g from GetClient(), fixed discovered object counting
@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/vsphere labels Jun 17, 2019
@@ -98,6 +98,8 @@ func (p *PointParser) Parse(buf []byte) ([]telegraf.Metric, error) {
buf = append(buf, []byte("\n")...)
}

//log.Printf("D! [parsers.wavefront] Received data: %s", string(buf))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

plugins/inputs/vsphere/README.md Outdated Show resolved Hide resolved
@prydin
Copy link
Contributor Author

prydin commented Aug 13, 2019

@danielnelson This PR will most likely generate a nasty merge with the vSAN stuff that @YuxinZhou is working on. How do you want me to handle that? Just wait for her merge to clear and then clean up the merge on my fork? Or you want us to merge our two branches into one?

@danielnelson danielnelson added this to the 1.12.0 milestone Aug 15, 2019
@danielnelson
Copy link
Contributor

Unfortunately, I'm not going to have time to help finish the vSAN code for the upcoming 1.12 release. Let's merge this in and have @YuxinZhou base his code on it.

@danielnelson danielnelson merged commit 2755595 into influxdata:master Aug 15, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants