Fix templating patterns wildcard matching #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
changed the title
danielnelson
suggested changes
Jul 17, 2019
danielnelson
approved these changes
Jul 19, 2019
|
@danielnelson which milestone should we put this in? |
danielnelson
pushed a commit
that referenced
this pull request
Jul 22, 2019
(cherry picked from commit 77b1a43)
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5894
This fixes an issue within templating rules used by line formats like the graphite format. The templating rules do not exhaustively explore all matches. The moment a match is found at any level, if the search fails to match the filters children it will bail out and return a nil template (which gets replace by teh caller with a default template).
Instead the template should return to the previous successful match and check to see if a wildcard exists which can also be explored.
Required for all PRs: