Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the pg_stat_bgwriter view #683

Closed
wants to merge 7 commits into from
Closed

Add the pg_stat_bgwriter view #683

wants to merge 7 commits into from

Conversation

menardorama
Copy link
Contributor

Hi,

I am adding more metrics on the postgresql plugin, my first one is the pg_stat_bgwriter view useful to get some performance informations.

In order to keep a small code, I've setup a check in the accRow function because this view don't provide the dbname (that's a cluster view).

As those metrics are purely system, the dbname is set to postgres dbname which can make sense.

Don't hesitate to give me a feedback even if it's bad :)

I am planning to implement more stats

@sparrc
Copy link
Contributor

sparrc commented Feb 11, 2016

unit tests need to be updated for this

@menardorama
Copy link
Contributor Author

Hi

Thanls for the feedback, I already saw the unit test result.

But I'm still dealing with a global column list slice which seems to be the issue.

I'm new to golang it can take time.

Any help would be appreciated, I have more query to add....

Thanks

@menardorama
Copy link
Contributor Author

OK I finally completed correctly the test plan

@sparrc sparrc closed this in 72f5c9b Feb 12, 2016
geodimm pushed a commit to miketonks/telegraf that referenced this pull request Mar 10, 2016
Add pg_stat_bg_writer stats

closes influxdata#683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants