Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add udp internal metrics for the statsd input #6921

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Add udp internal metrics for the statsd input #6921

merged 3 commits into from
Jan 22, 2020

Conversation

danielnelson
Copy link
Contributor

Add additional counters for statsd in udp mode.

closes: #6779

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin performance problems with decreased performance or enhancements that improve performance area/statsd labels Jan 17, 2020
@danielnelson danielnelson added this to the 1.14.0 milestone Jan 17, 2020
@danielnelson danielnelson mentioned this pull request Jan 17, 2020
Closed
@danielnelson
Copy link
Contributor Author

reimda
reimda suggested changes Jan 17, 2020
View reviewed changes
plugins/inputs/statsd/statsd.go Outdated
@@ -461,6 +469,8 @@ func (s *Statsd) udpListen(conn *net.UDPConn) error {
}
return err
}
s.UDPPacketsRecv.Incr(1)
s.UDPBytesRecv.Incr(int64(1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be incremented by n, not 1?

@danielnelson
Copy link
Contributor Author

With fixed udp_bytes_received:

@danielnelson danielnelson mentioned this pull request Jan 22, 2020
Merged
@danielnelson danielnelson merged commit 9243ae9 into master Jan 22, 2020
@danielnelson danielnelson deleted the statsd-stats branch January 22, 2020 23:28
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@danielnelson
Add udp internal metrics for the statsd input (influxdata#6921)
ce89e5b
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@danielnelson
Add udp internal metrics for the statsd input (influxdata#6921)
547a942
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@danielnelson
Add udp internal metrics for the statsd input (influxdata#6921)
92ee45e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimda reimda reimda approved these changes

Assignees
No one assigned
Labels
area/statsd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin performance problems with decreased performance or enhancements that improve performance
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Add UDP internal metrics to statsd input
2 participants
@danielnelson @reimda