Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal metrics for output split into multiple lines #7119

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

danielnelson
Copy link
Contributor

Fix a issue where the internal metrics were split over two lines unnecessarily due to the alias tag being set to the empty string.

1.13.4

> internal_write,host=loaner,output=kafka,version=unknown errors=0i,metrics_filtered=0i,write_time_ns=0i 1583447470000000000
> internal_write,host=loaner,output=kafka,version=unknown buffer_limit=10000000i,buffer_size=0i,metrics_added=0i,metrics_dropped=0i,metrics_written=0i 1583447470000000000

With change

internal_write,host=loaner,output=file,version=unknown buffer_limit=10000000i,buffer_size=0i,errors=0i,metrics_added=0i,metrics_dropped=0i,metrics_filtered=0i,metrics_written=0i,write_time_ns=0i 1583447704000000000

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the fix pr to fix corresponding bug label Mar 5, 2020
@danielnelson danielnelson added this to the 1.14.0 milestone Mar 5, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Mar 5, 2020

Nice catch. We might want to add a test to avoid a regression

@danielnelson danielnelson merged commit c50b02e into master Mar 10, 2020
@danielnelson danielnelson deleted the merge-output-selfstats branch March 10, 2020 22:19
Trovalo pushed a commit to Trovalo/telegraf that referenced this pull request Mar 11, 2020
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
veorlo pushed a commit to GlobalNOC/telegraf that referenced this pull request May 4, 2020
HarshitOnGitHub pushed a commit to HarshitOnGitHub/telegraf that referenced this pull request May 8, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants