Apply ping deadline to dns lookup #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutler-starry
force-pushed
the
dbutler/ping-dns-timeout
branch
from
e92a538
to
e734785
Compare
|
Had trouble coming up with a good way to test the timeout but open to suggestions |
danielnelson
suggested changes
Mar 9, 2020
plugins/inputs/ping/ping.go
Outdated
| error := make(chan error) | ||
|
|
||
| go func() { | ||
| addrs, err := net.ResolveIPAddr(network, destination) |
There was a problem hiding this comment.
If we create a Resolver we can use the functions that take a Context, this would be my preferred method to timeout the lookup since it won't leave a goroutine orphaned and should be simpler.
dbutler-starry
force-pushed
the
dbutler/ping-dns-timeout
branch
3 times, most recently
from
e6af512
to
a9288bd
Compare
dbutler-starry
force-pushed
the
dbutler/ping-dns-timeout
branch
from
a9288bd
to
4b17151
Compare
|
Modified to use |
|
@danielnelson Is this what you had in mind? |
danielnelson
approved these changes
Mar 25, 2020
danielnelson
added
the
feat
denzilribeiro
pushed a commit
to denzilribeiro/telegraf
that referenced
this pull request
Mar 27, 2020
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
veorlo
pushed a commit
to GlobalNOC/telegraf
that referenced
this pull request
May 4, 2020
HarshitOnGitHub
pushed a commit
to HarshitOnGitHub/telegraf
that referenced
this pull request
May 8, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes dns lookup in ping deadline. The deadline context is used for performing dns lookups, thus a ping collection will fail if the dealine times out during a lookup
Fixes #5059
Required for all PRs: