Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pugins/outputs/influxdb: Prevent runtime panic. #715

Closed
wants to merge 1 commit into from

Conversation

netixen
Copy link
Contributor

@netixen netixen commented Feb 18, 2016

  • Check and return error from NewBatchPoints to prevent runtime panic if
    user provides an unparsable precision time unit in config.
  • Provide correct sample config precision examples.

@@ -48,7 +48,7 @@ var sampleConfig = `
urls = ["http://localhost:8086"] # required
### The target database for metrics (telegraf will create it if not exists)
database = "telegraf" # required
### Precision of writes, valid values are n, u, ms, s, m, and h
### Precision of writes, valid values are "ns", "us" (or "µs"), "ms", "s", "m", "h".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update etc/telegraf.conf with this comment as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

- Check and return error from NewBatchPoints to prevent runtime panic if
   user provides an unparsable precision time unit in config.
- Provide correct sample config precision examples.
- Update etc/telegraf.conf precision comment.
@sparrc
Copy link
Contributor

sparrc commented Feb 18, 2016

looks good, thanks @netixen! 👍

@sparrc sparrc closed this in a13d19c Feb 18, 2016
geodimm pushed a commit to miketonks/telegraf that referenced this pull request Mar 10, 2016
- Check and return error from NewBatchPoints to prevent runtime panic if
   user provides an unparsable precision time unit in config.
- Provide correct sample config precision examples.
- Update etc/telegraf.conf precision comment.

closes influxdata#715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants