Add nagios parser for exec input plugin #762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +64,12 @@ func (c CommandRunner) Run(e *Exec, command string) ([]byte, error) { | |||
| cmd.Stdout = &out | |||
|
|
|||
| if err := cmd.Run(); err != nil { | |||
| return nil, fmt.Errorf("exec: %s for command '%s'", err, command) | |||
| switch e.parser.(type) { | |||
| case *nagios.NagiosParser: | |||
There was a problem hiding this comment.
why ignore errors for nagios commands?
There was a problem hiding this comment.
Because nagios plugins use exit code to indicate check status
- 0 == OK
- 1 == WARNING
- 3 == CRITICAL
- 4 or more == UNKNOWN
Maybe I should add a state metric for it ?
There was a problem hiding this comment.
adding a state metric seems like a good idea, if that's possible
titilambert
force-pushed
the
nagios
branch
3 times, most recently
from
c84a3ca
to
afd2b03
Compare
|
@titilambert so is the nagios parser only applicable to the exec plugin? Could you also write something in the docs/DATA_FORMAT_INPUTS.md doc? |
|
@sparrc Doc added ! Thanks ! |
|
|
||
| ## Nagios: | ||
|
|
||
| There are no additional configuration options for Nagios line-protocol. The |
There was a problem hiding this comment.
in here mention that the nagios parser is only for exec
|
I'm ready to merge this, can you rebase first? |
titilambert
force-pushed
the
nagios
branch
2 times, most recently
from
79655e5
to
3a162e8
Compare
|
@sparrc done ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ! This adds nagios parser for exec input plugin