fix ping exit code handling on non-Linux #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSD-derived ping's use exit code 2 for timeout, not 1
ssoroka
approved these changes
Jun 9, 2020
|
@nferch Can you sign the CLA? I'm also thinking about deprecating the ping executable, have you tried |
|
@danielnelson Couldn't figure out how to grant a non-root user the capability to use raw or ICMP sockets on FreeBSD, so used the exec ping. I'd also imagine there's some users that can't/won't address giving a non-root user the capabilities on Linux, so retaining Perhaps Will look into the CLA. |
danielnelson
pushed a commit
that referenced
this pull request
Jun 22, 2020
(cherry picked from commit 423fc28)
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSD-derived ping's use exit code 2 for timeout, not 1
Required for all PRs: