Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a dedicated parser for prometheus #7778

Merged
merged 8 commits into from
Dec 2, 2020

Conversation

DmitrySenin
Copy link
Contributor

@DmitrySenin DmitrySenin commented Jul 2, 2020

closes: #4414

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Testing

Tested locally with the following configuration of input:

[[inputs.http_listener_v2]]
  service_address = ":8094"
  path = "/metrics/job/fqt"
  data_format = "prometheus"

@DmitrySenin DmitrySenin changed the title Introduce a dedicate parser for prometheus Introduce a dedicated parser for prometheus Jul 2, 2020
@danielnelson
Copy link
Contributor

Since metric_version = 1 is deprecated now, I'd like to keep its use limited to backwards compatibility. Do you think you could split the code so that v1 is only available on the prometheus input and the new parser only does v2?

@DmitrySenin
Copy link
Contributor Author

@danielnelson , sure. Done

@danielnelson danielnelson added this to the 1.16.0 milestone Jul 7, 2020
@DmitrySenin
Copy link
Contributor Author

@danielnelson , Any chance to include it into 1.15? My team is looking forward to this functionality

@danielnelson
Copy link
Contributor

Sorry, we have missed the merge window for 1.15, it will have to go in 1.16.

Copy link

@platan platan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a Telegraf user interested in this feature. I've left some comments, hope it helps you.

docs/DATA_FORMATS_INPUT.md Outdated Show resolved Hide resolved
plugins/parsers/prometheus/README.md Outdated Show resolved Hide resolved
plugins/parsers/prometheus/parser_test.go Show resolved Hide resolved
@jakemcc
Copy link
Contributor

jakemcc commented Aug 3, 2020

Just stumbled across this and thought I'd add a comment that we'd also find this useful. Thanks for doing the work.

@jakemcc
Copy link
Contributor

jakemcc commented Sep 10, 2020

Just checking in on this. Anything missing that I might be able to help with?

@sjwang90 sjwang90 modified the milestones: 1.16.0, Planned Sep 14, 2020
- Small correction - added full stop
@jakemcc
Copy link
Contributor

jakemcc commented Sep 24, 2020

Not saying this to put any pressure on this being merged but just wanted to report I've been running a build of telegraf with this change and am successfully reporting metrics using it. Thanks for doing the work. 👏 👏 👏

Thanks everyone for putting work in to both manage this project and submit PRs.

@p-zak
Copy link
Collaborator

p-zak commented Nov 4, 2020

@DmitrySenin it seems that there is conflict with plugins/inputs/prometheus/parser.go

@BlueskyFR
Copy link

This should get merged!

@reimda reimda merged commit 0ccb134 into influxdata:master Dec 2, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prometheus parser and serializer
9 participants