Recv next message after send returns EOF in gnmi input #7872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be worth rerunning it a couple of times to see what happens? |
|
BTW, It seems the gRPC library is setup like this so that normally you would call Send and Recv from separate goroutines and each would know when to exit. It is also documented that Send can block if Recv is not being called, so it may even be possible for the plugin as it is now to deadlock, although I think it is unlikely or even impossible since we Send once/Recv once in lockstep. |
|
Ran the workflow 3 times with no failures: https://circleci.com/gh/influxdata/workflows/telegraf/tree/fix-gnmi-test |
danielnelson
added a commit
that referenced
this pull request
Jul 21, 2020
(cherry picked from commit b9a7188)
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the intermittent test failure.
#Required for all PRs: