Multiple escaping occurs on Jenkins URLs at certain folder depth #8048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appending when the capacity of the slice does not change results in a reference to the same location in memory, resulting in the call to PathEscape on combinedEscaped changing the contents of jr.parents mysteriously. Co-author: @hansnqyr
medains
changed the title
Fix go fmt
medains
changed the title
|
Please someone merge this PR. I have compiled this branch and tested the fix with lots of weird (production) paths and folder depths including spaces, hyphens and special chars. Worked flawlessly. Thank you @medains ! |
|
Tested few mine job paths - seems to work. |
ssoroka
approved these changes
Oct 7, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: