fix: plugins/parsers/influx: avoid ParseError.Error panic #8177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A line ends at `\n` or `\r\n`, but not `\r` on its own. The ParseError.Error logic was assuming that any carriage return terminates the line. This caused a crash when the buffer is big, there's a single `\r` character and the error offset was after that, because it assumed that the offset is always before the end of the current line (a reasonable assumption as long as the line-termination logic agrees between the Error method and the parsing code). This bug found by running `go-fuzz`.
ssoroka
approved these changes
Sep 30, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A line ends at
\nor\r\n, but not\ron its own. The ParseError.Errorlogic was assuming that any carriage return terminates the line.
This caused a crash when the buffer is big, there's a single
\rcharacter and theerror offset was after that, because it assumed that the offset is always before
the end of the current line (a reasonable assumption as long as the line-termination
logic agrees between the Error method and the parsing code).
This bug found by running
go-fuzz.Required for all PRs: