Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "name" parameter to NATS output plugin #8429

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Added "name" parameter to NATS output plugin #8429

merged 2 commits into from
Nov 27, 2020

Conversation

oplehto
Copy link
Contributor

@oplehto oplehto commented Nov 18, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Added name parameter to the NATS output plugin. The connection name simplifies monitoring, debugging and reporting.

See: https://docs.nats.io/developing-with-nats/connecting/name

@oplehto oplehto changed the title Added name parameter to NATS output Added "name" parameter to NATS output plugin Nov 18, 2020
@srebhan srebhan self-assigned this Nov 18, 2020
@sjwang90 sjwang90 added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Nov 18, 2020
@ssoroka ssoroka removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 19, 2020
@srebhan
Copy link
Member

srebhan commented Nov 26, 2020

@oplehto could you please add the new option to the README.md file as well!?

@srebhan srebhan requested a review from ssoroka November 27, 2020 08:23
srebhan
srebhan approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 27, 2020
@ssoroka ssoroka merged commit f5d5a51 into influxdata:master Nov 27, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Nov 27, 2020

Thank you!

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@oplehto
Added "name" parameter to NATS output plugin (influxdata#8429)
56204e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oplehto @srebhan @ssoroka @sjwang90