Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for linux/ppc64le #8432

Merged
merged 2 commits into from
Nov 30, 2020
Merged

add support for linux/ppc64le #8432

merged 2 commits into from
Nov 30, 2020

Conversation

aklyachkin
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Issue #8431

zak-pawel
zak-pawel reviewed Nov 22, 2020
View reviewed changes
Copy link
Collaborator

@zak-pawel zak-pawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't ppc64le also be added to scripts/release.sh? And what about link to nightly build in README.md?

@reimda @ssoroka ?

@reimda
Copy link
Contributor

reimda commented Nov 22, 2020

It looks like scripts/release.sh and the readme will need to be updated.

Also, don't debian-based distributions call it ppc64el? We will want to name the packages whatever is customary for the distribution.
https://wiki.ubuntu.com/ppc64el
https://wiki.debian.org/ppc64el

@aklyachkin
Copy link
Contributor Author

Hi, @zak-pawel and @reimda I added the changes. Now it should produce the ppc64el_deb for Debian, I added nightly build link into README.md and ppc64le into release.sh. Please check, if it is ok.

@sjwang90 sjwang90 added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Nov 25, 2020
@zak-pawel
Copy link
Collaborator

LGTM!

@ssoroka ?

@zak-pawel zak-pawel added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 30, 2020
@ssoroka ssoroka merged commit a748421 into influxdata:master Nov 30, 2020
@ssoroka ssoroka mentioned this pull request Nov 30, 2020
Closed
@sspaink sspaink mentioned this pull request Oct 7, 2021
Closed
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@aklyachkin
add support for linux/ppc64le (influxdata#8432)
af5b606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zak-pawel zak-pawel zak-pawel left review comments

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aklyachkin @reimda @zak-pawel @ssoroka @sjwang90