Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable kafka zstd compression and idempotent writes #8435

Merged
merged 12 commits into from
Nov 23, 2020
Merged

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Nov 19, 2020

closes #7647
closes #7123

@ssoroka ssoroka requested a review from reimda November 19, 2020 16:38
Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like how you factored out common settings.

plugins/inputs/kafka_consumer/README.md Outdated Show resolved Hide resolved
plugins/outputs/kafka/kafka.go Outdated Show resolved Hide resolved
plugins/outputs/kafka/README.md Outdated Show resolved Hide resolved
plugins/outputs/kafka/README.md Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/kafka_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/kafka_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/kafka_consumer/README.md Outdated Show resolved Hide resolved
@ssoroka ssoroka merged commit 8b30bb9 into master Nov 23, 2020
@ssoroka ssoroka deleted the kafka-zstd branch November 23, 2020 20:52
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable idempotence for Kafka output plugin (partial exactly-once support) Support Kafka zstd compression
3 participants