Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp column support to postgresql_extensible #8602

Conversation

tfoldi
Copy link
Contributor

@tfoldi tfoldi commented Dec 20, 2020

Implements #8601

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Copy link
Contributor

@ivorybilled ivorybilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@srebhan srebhan self-assigned this Jan 4, 2021
@srebhan srebhan added area/postgresql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 4, 2021
Comment on lines +303 to +305
if v, ok := (*val).(time.Time); ok {
timestamp = v
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to consider string fields that need to be parsed as timestamps, but this could be handled later.

@ssoroka ssoroka merged commit 0c99ae9 into influxdata:master Jan 11, 2021
@tfoldi tfoldi deleted the feat/postgresql_extensible_timestamp_from_field branch January 11, 2021 19:17
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/postgresql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants