Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs.ping regression: Add back required "hostPinger" function for "exec" method #8764

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Jan 28, 2021

Required for all PRs:

  • Has appropriate unit tests.

fixes #8766

This pull request addresses the issue @NZSmartie found and reported in #8704. There was a regression due to the pr #8679 which removed a required function which led to a instant panic when using the "exec" method for inputs.ping. I added an integration unit test to cover for this case in the future that ensures init() is correct.

@sspaink sspaink requested a review from ssoroka January 28, 2021 04:13
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@digitalcircuit
Copy link

Thank you for fixing this!

For those who have encountered this issue via an Internet search and want to downgrade Telegraf until a fixed release is available, as of now it is still possible to download the previous Telegraf version from the official downloads portal.

For example, on Debian/Ubuntu, instead of fetching telegraf_1.17.1-1_amd64.deb, you'd download telegraf_1.17.0-1_amd64.deb.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@digitalcircuit can you confirm that this change fixes the problem?

@srebhan
Copy link
Member

srebhan commented Jan 28, 2021

@sspaink please add a "Fixes #..." to the PR description. This way the issue is also closed when this is merged IIRC.

@srebhan srebhan self-assigned this Jan 28, 2021
@srebhan srebhan added area/ping fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 28, 2021
@ssoroka ssoroka merged commit 03fe914 into influxdata:master Jan 28, 2021
@digitalcircuit
Copy link

@srebhan Pardon the delay, I've only just now had the time to test this.

✔️ After compiling from source and building the appropriate package (had to also install fpm), Telegraf works with the same configuration that had previously crashed!

$ sudo dpkg -i telegraf_1.18.0~244178e5-0_amd64.deb
[…trimmed dpkg output…]
$ systemctl status telegraf.service
[…]
     Active: active (running) since Thu 2021-01-28 14:22:07 EST; 3min 18s ago
[…]
$ telegraf --version
Telegraf unknown (git: master 244178e5)

@tarjei
Copy link

tarjei commented Jan 28, 2021

Any ETA on when the PPAs will be updated?

ssoroka pushed a commit that referenced this pull request Jan 28, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ping fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.ping: Old/default "exec" method segfaults
5 participants