Bug Fix - SQL Server HADR queries for SQL Versions #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
|
Sorry this is beyond my SQL capabilities... :-) |
masree
reviewed
Feb 8, 2021
masree
reviewed
Feb 9, 2021
masree
reviewed
Feb 9, 2021
|
Thank you for the fix! Looks good to me! |
…mments for description
masree
approved these changes
Feb 11, 2021
Trovalo
approved these changes
Feb 12, 2021
|
closes #8750 |
3 tasks
helenosheaa
suggested changes
Feb 26, 2021
Trovalo
approved these changes
Feb 26, 2021
helenosheaa
approved these changes
Feb 26, 2021
|
Thank you @Trovalo for helping with the clarifications and approval. And thank you @helenosheaa for merging the PR. I'll resolve the open conversation in the above thread. |
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This PR fixes a bug in SqlServer plugin's HADR queries where various SQL Server versions (from 2012 onwards) were not handled, and causes the plugin to report failures for 2012 and 2014 versions.
closes #8750