Fix mutex locking around ifname cache #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tries so a read lock isn't enough
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
Hipska
approved these changes
Feb 19, 2021
Hipska
added
the
ready for final review
ivorybilled
reviewed
Feb 19, 2021
| // Cache it, then signal any other waiting requests for this agent | ||
| // and clean up | ||
| d.rwLock.Lock() | ||
| // snmp success. Cache response, then signal any other waiting |
There was a problem hiding this comment.
nit: any reason for having the two spaces after the period?
There was a problem hiding this comment.
When I learned to type that's what they taught in school. I'm aware that single space is more common now but it's a habit.
ivorybilled
approved these changes
Feb 19, 2021
|
!signed-cla |
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8842