Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max open requests to one if idempotent writes is set to true #8954

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

helenosheaa
Copy link
Member

Currently if idempotent_writes is set to true telegraf crashes

Idempotent_writes requires max open requests to be set to 1 (defaults to 5)

Change config to set max open requests to 1 under the hood when idempotent_writes is turned on

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 8, 2021
@helenosheaa helenosheaa requested a review from ssoroka March 8, 2021 16:14
@helenosheaa helenosheaa merged commit 372004a into master Mar 8, 2021
@helenosheaa helenosheaa deleted the kafka-idempotent-writes-fix branch March 8, 2021 16:38
ssoroka pushed a commit that referenced this pull request Mar 10, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants