Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a check for oid and name to prevent empty metrics #9366

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

MyaLongmire
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #8840 SNMP input can produce metrics with empty metric name

Added a check for empty oid and empty name
fixed an existing unit test to give the table a name
and added a test for a table with empty oid and empty name

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 14, 2021
@sspaink sspaink merged commit b846c50 into master Jun 22, 2021
@sspaink sspaink deleted the snmp-empty-metric-name branch June 22, 2021 20:59
reimda pushed a commit that referenced this pull request Jul 7, 2021
@Hipska
Copy link
Contributor

Hipska commented Jul 9, 2021

Did this pass all tests? Cause it makes telegraf to crash when you use ifName processor!

@Hipska
Copy link
Contributor

Hipska commented Jul 9, 2021

It did pass the tests, more disturbing is that the specific ifname test has been disabled in #8725 😱

@MyaLongmire MyaLongmire restored the snmp-empty-metric-name branch July 19, 2021 16:11
@MyaLongmire MyaLongmire mentioned this pull request Jul 19, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMP input can produce metrics with empty metric name
3 participants