Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rabbitmq federation plugin optional #9505

Closed
wants to merge 1 commit into from

Conversation

pabigot
Copy link
Contributor

@pabigot pabigot commented Jul 14, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #9489

Do not record an error for a 404 return for api/federation-links.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 14, 2021
@srebhan
Copy link
Member

srebhan commented Jul 15, 2021

Hey @pabigot, thanks for submitting this PR!

I wonder why you can't use metric_include or metric_exclude introduced in PR #9443 using e.g.

metric_exclude = ["federation"]

to disable collection of federation information. Can you please explain the use-case this PR is covering that is beyond the above solution. It's for me to understand how those two things interact...

@pabigot
Copy link
Contributor Author

pabigot commented Jul 15, 2021

I wonder why you can't use metric_include or metric_exclude introduced in PR #9443

Because I didn't know about it. That feature isn't mentioned anywhere in #9383 no, it is, I just missed it, nor in the commit message that resolved it, and my scan of the changes to the source didn't pick it up.

It does work, though. Thanks.

@srebhan
Copy link
Member

srebhan commented Jul 15, 2021

@pabigot no worries and yes I could have documented the feature better. Sorry about this. I just wanted to make sure I don't miss something on your PR that is not covered by the referenced change. Have fun using telegraf!

@pabigot pabigot deleted the issue9489 branch July 15, 2021 10:12
@Dmaina5054
Copy link

Dmaina5054 commented Feb 6, 2022

metric_exclude = ["federation"]
Worked for me running influxdb:2.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rabbitmq plugin 1.19.1 api/federation-links failure
3 participants