feat: add Linux Volume Manager input plugin

[powersj]

The Logical Volume Management (LVM) input plugin collects information about
physical volumes, volume groups, and logical volumes. This will only
work on Linux and *BSDs as OS X and Windows do not have support for
these types of disks.

The metrics are broken out into the various LVM types.

Resolves: #345

Required for all PRs:

• Updated associated README.md.
• Wrote appropriate unit tests.
• Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

[sspaink]

Thanks for working on this, some minor comments.

[powersj]

Comments addressed, read for re-review

[telegraf-tiger]

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

• static_linux_amd64.tar.gz

• ppc64le.rpm

• linux_ppc64le.tar.gz

• ppc64el.deb

• s390x.rpm

• linux_s390x.tar.gz

• s390x.deb

• i386.rpm

• freebsd_i386.tar.gz

• linux_i386.tar.gz

• i386.deb

• darwin_amd64.tar.gz

• linux_mipsel.tar.gz

• mipsel.deb

• armel.rpm

• linux_armel.tar.gz

• armel.deb

• x86_64.rpm

• freebsd_amd64.tar.gz

• linux_amd64.tar.gz

• amd64.deb

• aarch64.rpm

• linux_arm64.tar.gz

• arm64.deb

• linux_mips.tar.gz

• mips.deb

• armv6hl.rpm

• freebsd_armv7.tar.gz

• linux_armhf.tar.gz

• armhf.deb

• windows_amd64.zip

• windows_i386.zip

[sspaink]

lgtm!

[rafaelreis-r]

Hey @powersj !

Just tried using your pluigin on Ubuntu 18.04 and noticed the pvs bin path is hardcoded:

[inputs.lvm] Error in plugin: failed to run command sudo -n /usr/sbin/pvs --reportformat json --units b --nosuffix -o pv_name,vg_name,pv_size,pv_free,pv_used: exit status 1 -

which pvs /sbin/pvs

Could you maybe expand the configuration to allow different paths or use system envs to do so?

[powersj]

@rafaelreis-r please file a bug and it is definitely something we can look at! Thanks!

[c4baceira]

hello @powersj !

Is this plugin ready to be used by the docker version of Telegraf?

I'm getting:

2022-06-15T15:22:30Z E! [inputs.lvm] Error in plugin: failed to run command /usr/sbin/pvs --reportformat json --units b --nosuffix -o pv_name,vg_name,pv_size,pv_free,pv_used: fork/exec /usr/sbin/pvs: no such file or directory -

Using:

version: '3'

services:

 telegraf:
   image: telegraf
   container_name: telegraf
   restart: always
   volumes:
     - /var/run/docker.sock:/var/run/docker.sock:z
     - ./telegraf/telegraf.conf:/etc/telegraf/telegraf.conf:ro
   links:
     - influxdb
   ports:
     - "8092:8092/udp"
     - "8094:8094"
     - "8125:8125/udp"
   networks:
     - tick
   user: telegraf:118

telegraf --version
Telegraf 1.23.0 (git: HEAD 806dc283)

[powersj]

@c4baceira,

The docker image does not contain all the possible dependencies that every plugins would require. If we did, the docker image size would be huge to meet those requirements.

If you want to use this plugin with docer you will need to create a custom image that includes those binaries as well.