Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI ingress-nginx installation #322

Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix CI ingress-nginx installation #322

merged 1 commit into from
Jul 14, 2022

Conversation

kd7lxl
Copy link
Contributor

@kd7lxl kd7lxl commented Jul 14, 2022

The file we relied on previously to detect the latest ingress-nginx version was removed, so I changed it to use the release tags.

kubernetes/ingress-nginx#8778

The file we relied on previously to detect the latest ingress-nginx version was removed, so I changed it to use the release tags.

kubernetes/ingress-nginx#8778
@kd7lxl kd7lxl requested a review from a team as a code owner July 14, 2022 20:10
@kd7lxl
Copy link
Contributor Author

kd7lxl commented Jul 14, 2022

Note that the upgrade job is expected to fail because it tries to install based on what is currently in main, which is broken, and the reason for this PR.

Copy link

@hramazani hramazani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kd7lxl kd7lxl merged commit f53a20c into main Jul 14, 2022
@kd7lxl kd7lxl deleted the fix-ci-ing branch July 14, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants